DjangoBot: #django-dev

Well, I just posted this in #django, but I will give it another try here (maybe a different audience)

I'm doing some work on ticket #7199 and it seems to be a problem in the where clause of the SQL statement that is being issued.

However, I am having trouble finding where in the code that SQL is generated.

Any pointers on where to look?

StevenPotter: look on django/db/models/sql/where.py and query.py

StevenPotter: can you reproduce the probmen with more than one db backend?

I don't know. I only know that the problem is present on MySQL

can you try on sqlite3?

I was just thinking I would give that a try.

I haven't used sqlite much. Is it possible to log the queries issued?

yes, using the same trick

Yes, it seems that the same problem exists with sqlite

maybe one of you could join this discussion here: http://thread.gmane.org/gmane.comp.python.devel...

(about an ordered dict implementation in the stdlib)

i know django uses ordered dicts, maybe you could bring your expertise in

any newforms-admin people around who can give a quick code review to my solution for the relative path problem?

rats, that's the wrong patch

http://dpaste.com/hold/56735/ is correct (uses root_path instead of admin_root)

I went through a bunch of iterations but in the end the cleanest solution seems to be to stash the calculated root path on the AdminSite instance itself, which can then be accessed from ModelAdmin instances through self.admin_site.root_path

mitsuhiko: not much I can add to that discussion, really like the way you've written / documented your odict.py module though

brosner: any chance you could glance over http://dpaste.com/hold/56735/ ? I think I've solved the relative path issue

SimonW: looks good to me. did you have tests for it?

did userlinks move up to a base template?

didn't move, it was always present in base.html

ah ok

it's just now there's no need to over-ride it in the various other templates

which also means that if you want to customise those links you can do so using your own base_site.html template

(at GCap we need to ditch the "change password" link as we manage passwords using LDAP, and we need the documentation link to point to our wiki since we don't want our end users seeing Django template / models docs)

there are also places in ModelAdmin with relative paths

in the actual code itself? stuff like redirects?

hmm... should fix those too

yeah redirects

I haven't touched the breadcrumb code yet either

SimonW: i'm writing a pep now. birkenfeld thinks that's the best way to get that implemented :)

as long as there's nothing wrong with the basic approach (I'm pretty sure there isn't) I'll crack on with fixing those other bits and check it in

yeah sounds good to me

the basic approach looks solid

oh blast, just did a search in django/contrib/admin for "../" and there's a metric ton of stuff I missed

lots of it is in util.py and widgets.py, which probably won't have access to the AdminSite object

reckon it's worth checking in in two chunks? The fix I have at the moment doesn't break anything and adds some useful functionality (the ability to over-ride userlinks in base_site.html)

yeah, i forgot about the widgets

the further refactoring of redirects will actually involve some larger code changes so might be easier to follow in separate commits

agreed

rats, forgot the "newforms-admin: " tag on [7638]

i hate when i do that too

OK, I'm baffled by this

line 13 of django/contrib/admin/urls.py : http://code.djangoproject.com/browser/django/br...

urls.py isn't used

('^auth/user/add/$', 'django.contrib.admin.views.auth.user_add_stage') - but I can't find a "user_add_stage" function mentioned anywhere else in the code base?

aha!

the entry point for the site is AdminSite.root

any reason we can't just delete urls.py out right?

yeah it should be deleted. i was going to go through and kill dead code this week

so where's the custom view used for http://localhost:8000/admin/auth/user/add/ ? that's the view that only asks for a username and password to create a new user

I can't see where its URL is dealt with

cool, thanks - need to fix that one as well

brosner & SimonW as you are playing around with nfa, would you mind in commiting #5405? I know it's not critical, but due it's small impact it could be taken away from the list ;)

(yes, two days triaging and I just went to Ready for checkin)

Oh, only if the patch is still ok (it's 1 year old) if not let me know and I'll move it back to accepted

same for #5775 if applicable

DjangoBot, you seem to know a lot about tickets... tell me, when will we reach Point 0? hehe.. :P