DjangoBot: #django-dev

I've posted an invalid diff file on django trac and it was integrated in the trunk.. should I simply post the correct diff now?

the bad diff file was not generated in the django svn repo root dir

so it has revision 0 as both source and target revisions

RaceCondition: was the patch already applied and ticket closed?

empty: svn diff -r 7567 shows that its included

but the file that it adds to the repository does not exist after svn up

I'm having some hard time translating some strings in django -- they're really impossible to translate into Estonian

empty: sorry, I mistakenly thought my diff was applied to trunk. actually it hasn't been :)

yeah just upload a new patch.

RaceCondition: ^^

yep

empty: if I don't have admin privileges in Trac, I cannot replace my previously attached diff file which is invalid?

RaceCondition: we don't replace. Just add another one.

They like the history.

OK, fine

I wonder what's taking it so long for the diff to be integrated

how can I keep myself logged in to Trac so I wouldn't have to enter my name/email address when commenting a ticket?

oh, got it :) I'm a dumbass

wondering if adding a middleware class argument to specify dependency would solve the middleware ordering problem? E.g.: If auth middleware added a `depend = "django.contrib.sessions.middleware.SessionMiddleware"` and you had them in the wrong order in settings.py, it would automatically correct the order for that dependency tree only (so you still have some control). Care should be taken to not have a cycle in the dependency tree (should be a DAG).

robhudson: not a bad idea, though I'd more prefer it to just warn you about the order than to actually try any sort of automatic correction... but it's kinda compelling

robhudson: you can do that manually in you're middleware's __init__ by inspecting settings, fwiw.

what I like about a depends attribute is it puts the problem of dependency on the author of the middleware, who should know best about it. Agree that automatically re-ordering might be a bit much, but that would make it "just work" (unless you have cyclic dependencies), which is kinda nice.

I could play around with the idea and add a patch to #730 if interested

I could also look at making ./manage.py validate say something about middleware ordering if dependencies were specified.

robhudson: sure, sounds like a good plan

cool. seems like validate is a good 1st place to start anyway. I'll see what I can come up with. Sounds fun... I like playing with graphs.

there's a "tree" structure in django.utils now, I think

is there any graph stuff already in Django? any datastructures I can borrow?

ok, I'll check it

I thought malcolm added one for qsrf - take a look

hi!

can someone give me a hand with my Field.get_db_prep_* confusions?